Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package versions in API dump? Is this the intended behaviour? #14

Open
alaendle opened this issue Jul 26, 2024 · 5 comments
Open

Package versions in API dump? Is this the intended behaviour? #14

alaendle opened this issue Jul 26, 2024 · 5 comments

Comments

@alaendle
Copy link

Guess this is to avoid some ambiguities of symbols, but for some identifier I get packages with versions in my API dump.

E.g.

Call :: forall (m :: * -> *). bytestring-0.11.5.3:Data.ByteString.Internal.Type.ByteString -> Faas m (Data.Either.Either (GHC.Types.Int, bytestring-0.11.5.3:Data.ByteString.Internal.Type.ByteString) (bytestring-0.11.5.3:Data.ByteString.Internal.Type.ByteString, bytestring-0.11.5.3:Data.ByteString.Internal.Type.ByteString))

Or the same with aeson:

SetModuleTwinHandler :: forall a1 (m :: * -> *). (GHC.Classes.Eq a1, aeson-2.2.3.0:Data.Aeson.Types.FromJSON.FromJSON a1) => (a1 -> m ()) -> IoTHub m ()

But his just creates noise if the aeson/bytestring version changes, and also it feels inconsistent - e.g. Either or Int are not "package-prefixed".

@Kleidukos
Copy link
Owner

To answer your last sentence, I imagine it's because base and ghc-internal are not re-installable, and as such the version does not matter.

@Kleidukos
Copy link
Owner

This certainly makes me think about using a different backend for the interface dump. Thanks for reporting this.

@andreabedini
Copy link

How about this: hide the unit-id by default and show it only when there are multiple instances of a same package name (or requested by the user with a flag perhaps).

It requires a bit logic but nothing compared to what you have already done.

@Kleidukos
Copy link
Owner

Yes that could work. :)

@Kleidukos
Copy link
Owner

@andreabedini you reckon you could come up with a prototype PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants