From d79d0183e5408bd59e56202749299ae4bb417bb8 Mon Sep 17 00:00:00 2001 From: Artur Trzop Date: Fri, 6 Mar 2020 12:14:49 +0100 Subject: [PATCH 1/2] Pass non zero exit status from Cucumber as exit status for Cucumber executed in Queue Mode --- lib/knapsack_pro/runners/queue/cucumber_runner.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/knapsack_pro/runners/queue/cucumber_runner.rb b/lib/knapsack_pro/runners/queue/cucumber_runner.rb index 9863eb5f..5292035a 100644 --- a/lib/knapsack_pro/runners/queue/cucumber_runner.rb +++ b/lib/knapsack_pro/runners/queue/cucumber_runner.rb @@ -57,7 +57,7 @@ def self.run_tests(accumulator) all_test_file_paths += test_file_paths result_exitstatus = cucumber_run(runner, test_file_paths, args) - exitstatus = 1 if result_exitstatus != 0 + exitstatus = result_exitstatus if result_exitstatus != 0 # KnapsackPro::Hooks::Queue.call_after_subset_queue # KnapsackPro::Report.save_subset_queue_to_file From 41cddd5f0998288b8cbcea941cd57fe2de0f976e Mon Sep 17 00:00:00 2001 From: Artur Trzop Date: Fri, 6 Mar 2020 12:17:32 +0100 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index eced0280..7a7e760b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,13 @@ # Change Log +### 1.18.1 + +* Pass non zero exit status from Cucumber as exit status for Cucumber executed in Queue Mode + + https://github.com/KnapsackPro/knapsack_pro-ruby/pull/101 + +https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v1.18.0...v1.18.1 + ### 1.18.0 * __IMPORTANT__ Do not allow Fallback Mode when the CI node was retried to avoid running the wrong set of tests