From 1f1ef019e99a6decbc6d68814d6b9f92aa38db54 Mon Sep 17 00:00:00 2001 From: Artur Trzop Date: Thu, 8 Aug 2024 14:20:52 +0200 Subject: [PATCH 1/4] Add link to how to read the backtrace --- lib/knapsack_pro/runners/queue/base_runner.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/knapsack_pro/runners/queue/base_runner.rb b/lib/knapsack_pro/runners/queue/base_runner.rb index b3a74a08..5f432c7a 100644 --- a/lib/knapsack_pro/runners/queue/base_runner.rb +++ b/lib/knapsack_pro/runners/queue/base_runner.rb @@ -71,6 +71,7 @@ def log_threads puts '=' * 80 puts "Start logging #{threads.count} detected threads." puts 'Use the following backtrace(s) to find the line of code that got stuck if the CI node hung and terminated your tests.' + puts 'How to read the backtrace: https://knapsackpro.com/perma/ruby/backtrace-debugging' threads.each do |thread| puts From 731e6f79a1d932fb3c44b99be42ae14fbdde44b0 Mon Sep 17 00:00:00 2001 From: Artur Trzop Date: Thu, 8 Aug 2024 14:22:42 +0200 Subject: [PATCH 2/4] Update CHANGELOG.md --- CHANGELOG.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cf9ecdc6..47f17d50 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,14 @@ ### UNRELEASED +### 7.8.0 + +* Add link to how to read the backtrace. + + https://github.com/KnapsackPro/knapsack_pro-ruby/pull/267 + +https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v7.7.0...v7.8.0 + ### 7.7.0 * Log threads when the OS signal is received to simplify debugging, especially when a CI node hangs. From 6e5e72c5427ae2a7a799e26a4dccbf2d91bd6666 Mon Sep 17 00:00:00 2001 From: Artur Trzop Date: Thu, 8 Aug 2024 14:26:10 +0200 Subject: [PATCH 3/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 47f17d50..bd340825 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ ### 7.8.0 -* Add link to how to read the backtrace. +* Add a link to help you read the backtrace. https://github.com/KnapsackPro/knapsack_pro-ruby/pull/267 From dc0655d6c4447e6f5ba6e306005bad190376558d Mon Sep 17 00:00:00 2001 From: Artur Trzop Date: Thu, 8 Aug 2024 14:34:17 +0200 Subject: [PATCH 4/4] fix flaky test --- spec/integration/runners/queue/rspec_runner_spec.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spec/integration/runners/queue/rspec_runner_spec.rb b/spec/integration/runners/queue/rspec_runner_spec.rb index 4a8622fe..55a78133 100644 --- a/spec/integration/runners/queue/rspec_runner_spec.rb +++ b/spec/integration/runners/queue/rspec_runner_spec.rb @@ -1322,6 +1322,8 @@ def when_first_matching_example_defined(type:) Thread.new do sleep 10 end + + sleep 1 # wait for the above async thread to start end end SPEC