Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Implement a mode to abort if not all parameters are specified #25

Closed
minism opened this issue Jun 10, 2016 · 2 comments
Closed

[FR] Implement a mode to abort if not all parameters are specified #25

minism opened this issue Jun 10, 2016 · 2 comments
Assignees
Labels

Comments

@minism
Copy link

minism commented Jun 10, 2016

The default behavior of using empty string for unspecified parameters is OK for personal skeletons, but becomes problematic when you want to share your templates with team members and enforce a correct directory structure. Especially when combined with -f, because you need to manually clean up the incorrect files that were generated.

It would be nice to have a flag that aborts without creating any files if not all parameters are given.

@Knetic Knetic added the feature label Jun 10, 2016
@Knetic Knetic self-assigned this Jun 10, 2016
@Knetic
Copy link
Owner

Knetic commented Jun 10, 2016

Especially when combined with -f, because you need to manually clean up the incorrect files that were generated.

Workaround: you can use -d to make it delete the existing folder before it begins output. That'll remove any incorrect files.

However, I actually was a little unsatisfied with the default behavior. I always seem to generate a project a couple times, just to make sure i got the parameter right, this FR would make it a bit less messy to use a new template. This ticket motivated me to change the default behavior. Commit 89034fd implements this.

@Knetic Knetic closed this as completed Jun 10, 2016
@minism
Copy link
Author

minism commented Jun 10, 2016

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants