Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(konnect): fix panic in KonnectAPIAuthConfigurationReconciler #890

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 26, 2024

What this PR does / why we need it:

Which issue this PR fixes

Fixes #887

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek added this to the KGO v1.5.x milestone Nov 26, 2024
@pmalek pmalek self-assigned this Nov 26, 2024
@pmalek pmalek force-pushed the fix-panic-in-KonnectAPIAuthConfigurationReconciler branch 3 times, most recently from c778403 to 6cd5da6 Compare November 27, 2024 14:51
@pmalek pmalek marked this pull request as ready for review November 27, 2024 16:40
@pmalek pmalek requested a review from a team as a code owner November 27, 2024 16:40
@pmalek pmalek mentioned this pull request Nov 27, 2024
17 tasks
test/envtest/controller.go Show resolved Hide resolved
pkg/utils/kubernetes/status.go Outdated Show resolved Hide resolved
@pmalek pmalek force-pushed the fix-panic-in-KonnectAPIAuthConfigurationReconciler branch from 6dc42b8 to 57ffc53 Compare November 27, 2024 20:19
@pmalek pmalek enabled auto-merge (squash) November 27, 2024 20:19
@pmalek pmalek merged commit 03c540c into main Nov 27, 2024
21 checks passed
@pmalek pmalek deleted the fix-panic-in-KonnectAPIAuthConfigurationReconciler branch November 27, 2024 20:32
pmalek added a commit that referenced this pull request Nov 27, 2024
* fix(konnect): fix panic in KonnectAPIAuthConfigurationReconciler

* chore: refactor condition funcs
pmalek added a commit that referenced this pull request Nov 27, 2024
… (#901)

* fix(konnect): fix panic in KonnectAPIAuthConfigurationReconciler

* chore: refactor condition funcs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Konnect entities: panic observed in KonnectAPIAuthConfigurationReconciler
2 participants