feat(redis) support spec tests with redis cluster #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outsinre
force-pushed
the
FTI-2014-support-redis-cluster
branch
from
91bcb8d to
981bc47
Compare
outsinre
force-pushed
the
FTI-2014-support-redis-cluster
branch
2 times, most recently
from
bf7610e to
250f9fb
Compare
Kong currently does not support connection to redis cluster and will be fixed in FTI-2014. We should support an ENV to load redis cluster seeds: KONG_SPEC_TEST_REDIS_CLUSTER_ADDRESSES
outsinre
force-pushed
the
FTI-2014-support-redis-cluster
branch
from
250f9fb to
30b340d
Compare
|
Hey, looking good! can you add a changelog entry? |
Tieske
approved these changes
Aug 31, 2022
|
nvm added it already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kong currently does not support connection to redis cluster and will
be fixed in FTI-2014.
We should support an ENV to load redis cluster seeds:
KONG_SPEC_TEST_REDIS_CLUSTER_ADDRESSES