Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dockerfiles): clean up dangling sockets on startup (#10468) #10481

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

locao
Copy link
Contributor

@locao locao commented Mar 14, 2023

FTI-4525

(cherry picked from commit a6fe370)

Summary

This change adds a clean-up step to remove all sockets that a previous Kong run may have left in $PREFIX directory.

Checklist

Full changelog

Dangling unix sockets have been a pain point in recent Kong versions and was dealt in traditional Kong in #9254, but the kong script is not called when starting Kong inside a container, so a similar change to dockerfiles/entrypoint.sh was added here.

Issue reference

FTI-4525

@locao locao requested a review from dndx March 14, 2023 18:22
CHANGELOG.md Outdated Show resolved Hide resolved
@chronolaw
Copy link
Contributor

I create a typo fix PR(#10482) for the original PR.

Co-authored-by: Chrono <chrono_cpp@me.com>
@bungle
Copy link
Member

bungle commented Mar 15, 2023

@locao should we squash and merge? If not then we need to fix the commits to proper format.

@locao
Copy link
Contributor Author

locao commented Mar 15, 2023

@bungle I'll squash them, thanks!

@locao locao merged commit f9a332d into release/3.2.x Mar 15, 2023
@locao locao deleted the backport-10468-to-release/3.2.x branch March 15, 2023 15:21
@hbagdi
Copy link
Member

hbagdi commented Mar 15, 2023

Does this require any special handling in the EE codebase?

@kikito kikito mentioned this pull request Mar 16, 2023
@locao
Copy link
Contributor Author

locao commented Mar 16, 2023

Yes, I cherry-picked in Kong/kong-ee#4803.

@kikito kikito mentioned this pull request Mar 16, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants