-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(clustering): gather clustering events into one place #9671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
force-pushed
the
refactor/separate_clustering_events
branch
from
November 16, 2022 23:18
ec1005c
to
5f6b371
Compare
dndx
approved these changes
Nov 18, 2022
dndx
force-pushed
the
refactor/separate_clustering_events
branch
from
November 18, 2022 07:25
ac5ea4a
to
34cb982
Compare
It may conflict with the feature "backup config sync for CP outage", I suggest merging it after 3.1 release. |
This was referenced Dec 9, 2022
2 tasks
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
* fix(bazel): cp luarocks-admin to bin * chore: add changelog re: luarocks-admin * chore: accept gha changelog suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To prepare for incremental sync and other features,
We must do some code clean for event propagation.
Full changelog
events.lua
events.lua
events.clustering_push_config