Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(clustering): gather clustering events into one place #9671

Merged
merged 11 commits into from
Nov 22, 2022

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 3, 2022

Summary

To prepare for incremental sync and other features,
We must do some code clean for event propagation.

Full changelog

  • Add a new file events.lua
  • Move event register functions into events.lua
  • New function events.clustering_push_config

@chronolaw chronolaw marked this pull request as ready for review November 3, 2022 07:13
@chronolaw chronolaw requested a review from a team as a code owner November 3, 2022 07:13
@chronolaw chronolaw force-pushed the refactor/separate_clustering_events branch from ec1005c to 5f6b371 Compare November 16, 2022 23:18
kong/clustering/events.lua Outdated Show resolved Hide resolved
@dndx dndx force-pushed the refactor/separate_clustering_events branch from ac5ea4a to 34cb982 Compare November 18, 2022 07:25
@chronolaw
Copy link
Contributor Author

chronolaw commented Nov 18, 2022

It may conflict with the feature "backup config sync for CP outage", I suggest merging it after 3.1 release.

@dndx dndx merged commit 3900eb4 into master Nov 22, 2022
@dndx dndx deleted the refactor/separate_clustering_events branch November 22, 2022 07:02
oowl pushed a commit that referenced this pull request Aug 15, 2024
* fix(bazel): cp luarocks-admin to bin

* chore: add changelog re: luarocks-admin

* chore: accept gha changelog suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants