From 483b94dad3877d0abb4845cc5f88f027b543c44f Mon Sep 17 00:00:00 2001 From: Adam DeHaven Date: Mon, 26 Sep 2022 16:45:39 -0400 Subject: [PATCH] fix(kpop): always remove click listeners --- src/components/KPop/KPop.vue | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/components/KPop/KPop.vue b/src/components/KPop/KPop.vue index dbdbb8c6fc..9b9266f844 100644 --- a/src/components/KPop/KPop.vue +++ b/src/components/KPop/KPop.vue @@ -327,11 +327,12 @@ export default defineComponent({ }, beforeUnmount() { const popper = this.$refs.popper - if (popper && this.trigger === 'click') { - this.reference && this.reference.removeEventListener('click', this.handleClick) - popper.removeEventListener('click', this.showPopper) - document.documentElement.removeEventListener('click', this.handleClick) - } else if (this.reference) { + + document.documentElement.removeEventListener('click', this.handleClick) + popper && popper.removeEventListener('click', this.showPopper) + + if (this.reference) { + this.reference.removeEventListener('click', this.handleClick) this.reference.removeEventListener('mouseenter', this.createInstance) this.reference.removeEventListener('mouseleave', this.toggle) this.reference.removeEventListener('focus', this.createInstance)