From 8d128fd45df03bce4b408d18309065814475fe34 Mon Sep 17 00:00:00 2001 From: portikM Date: Wed, 16 Oct 2024 09:56:53 -0400 Subject: [PATCH] fix: address pr feedback --- docs/components/table-data.md | 8 ++------ docs/components/table-view.md | 2 +- src/components/KTableView/KTableView.vue | 2 +- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/docs/components/table-data.md b/docs/components/table-data.md index ebb6a1219e..075a3e6559 100644 --- a/docs/components/table-data.md +++ b/docs/components/table-data.md @@ -20,9 +20,9 @@ If you are looking for a simpler table component that does not integrate data fe ## Base KTableView Component -KTableData wraps the KTableView component, adding data fetching functionality. +KTableData wraps the KTableView component, adding data fetching functionality. -KTableData supports all [KTableView props](/components/table-view#props) (with the exception of `data` prop, which is replaced with [`fetcher` prop](#fetcher) in KTableData), [slots](/components/table-view#slots) and [events](/components/table-view#events) (with the exception of [pagination events](/components/table-view#pagination-events) which are not emitted by KTableData). `headers` and `hidePaginationWhenOptional` props as well as `update:table-preferences` event are handled slightly differently in KTableData. See below sections for details. +KTableData supports all [KTableView props](/components/table-view#props), except for the `data` prop, which is replaced by the [`fetcher` prop](#fetcher). It also supports [slots](/components/table-view#slots) and [events](/components/table-view#events), except for [pagination events](/components/table-view#pagination-events), which KTableData does not emit. Additionally, the `headers` prop and the `update:table-preferences` event are handled differently in KTableData. See the sections below for more details. ## Props @@ -315,10 +315,6 @@ A string that will passed to fetcher function and can be used to modify the API Set this to `false` to disable ability to sort. -### hidePaginationWhenOptional - -Set this to `true` to hide pagination when the table record count is less than or equal to the page size. Defaults to `false`. - ## Events ### state diff --git a/docs/components/table-view.md b/docs/components/table-view.md index 7223a3c2d1..91412aa9f0 100644 --- a/docs/components/table-view.md +++ b/docs/components/table-view.md @@ -701,7 +701,7 @@ A boolean to hide pagination element (defaults to `false`). ### hidePaginationWhenOptional -Set this to `true` to hide pagination when the table record count is less than or equal to the page size. Defaults to `true`. +Set this to `true` to hide pagination when the table record count is less than or equal to the page size. Defaults to `false`. ### rowExpandable diff --git a/src/components/KTableView/KTableView.vue b/src/components/KTableView/KTableView.vue index 75d8fd826a..c1ceca58a2 100644 --- a/src/components/KTableView/KTableView.vue +++ b/src/components/KTableView/KTableView.vue @@ -424,7 +424,7 @@ const props = withDefaults(defineProps(), { rowExpandable: () => false, hideHeaders: false, nested: false, - hidePaginationWhenOptional: true, + hidePaginationWhenOptional: false, hideToolbar: false, /** * KTableData props defaults