Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): sass @import to @use [KHCP-13755] #2518

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Nov 14, 2024

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-14088

Build size

Screenshot 2024-11-15 at 9 51 00 AM

Build size for main:

Screenshot 2024-11-15 at 9 51 57 AM

@portikM portikM self-assigned this Nov 14, 2024
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit c62d703
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/6737653360091300088686c1
😎 Deploy Preview https://deploy-preview-2518--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM changed the title Fix/khcp 13755 sass import to use fix(*): sass @import to @use [KHCP-13755] Nov 14, 2024
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit c62d703
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/673765332e24f60008cdb003
😎 Deploy Preview https://deploy-preview-2518--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM marked this pull request as ready for review November 15, 2024 14:54
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/.vitepress/theme/_variables.scss Show resolved Hide resolved
@import "./percy";
@use "./variables";
@use "./overrides";
@use "./percy";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You can actually remove anything with Percy; we don't use it anymore

@portikM portikM merged commit b3ec945 into main Nov 15, 2024
11 checks passed
@portikM portikM deleted the fix/khcp-13755-sass-import-to-use branch November 15, 2024 16:19
kongponents-bot pushed a commit that referenced this pull request Nov 15, 2024
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.14.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants