From adc9b7b0dd1ab158cd0a0d2a145ccb6cd6fbed67 Mon Sep 17 00:00:00 2001 From: portikM Date: Mon, 24 Jul 2023 15:48:57 -0400 Subject: [PATCH 1/2] feat(kskeleton): introduce kui tokens [KHCP-7723] --- docs/components/skeleton.md | 24 +++++++------- src/components/KSkeleton/CardSkeleton.vue | 31 ++++++++++------- src/components/KSkeleton/FormSkeleton.vue | 2 +- .../KSkeleton/FullScreenGenericSpinner.vue | 29 ++++++++-------- .../KSkeleton/FullScreenKongSkeleton.vue | 10 +++--- src/components/KSkeleton/KSkeleton.vue | 19 +++++------ src/components/KSkeleton/KSkeletonBox.vue | 5 +-- src/components/KSkeleton/TableSkeleton.vue | 33 ++++++++++++------- src/styles/_tmp-variables.scss | 2 ++ 9 files changed, 87 insertions(+), 68 deletions(-) diff --git a/docs/components/skeleton.md b/docs/components/skeleton.md index 42929f1ee4..957032058f 100644 --- a/docs/components/skeleton.md +++ b/docs/components/skeleton.md @@ -215,10 +215,10 @@ KSkeleton package uses a component to render the placeholder content ` @@ -333,13 +333,13 @@ And another example: ## Theming -| Variable | Purpose | -| :----------------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| `--KSkeletonFullScreenMargin` | Margin around full screen variant. Useful for when you want to show full screen loader under header or next to sidebar since the full screen component has fixed position. | -| `--KSkeletonFullScreenProgressBackgroundColor` | Progress bar background color. | -| `--KSkeletonFullScreenProgressColor` | Progress bar fill color. | -| `--KSkeletonFullScreenSpinnerColor` | Generic spinner icon fill color. | -| `--KSkeletonCardWidth` | Width of the card. Default is 33% | +| Variable | Purpose | +| :--------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | +| `--KSkeletonFullScreenMargin` | Margin around full screen variant. Useful for when you want to show full screen loader under header or next to sidebar since the full screen component has fixed position. | +| `--KSkeletonFullScreenProgressBackgroundColor` | Progress bar background color. | +| `--KSkeletonFullScreenProgressColor` | Progress bar fill color. | +| `--KSkeletonFullScreenSpinnerColor` | Generic spinner icon fill color. | +| `--KSkeletonCardWidth` | Width of the card. Default is 33% | ### Examples @@ -418,7 +418,7 @@ export default defineComponent({ diff --git a/src/components/KSkeleton/FullScreenGenericSpinner.vue b/src/components/KSkeleton/FullScreenGenericSpinner.vue index 63fcd8df33..67239166a1 100644 --- a/src/components/KSkeleton/FullScreenGenericSpinner.vue +++ b/src/components/KSkeleton/FullScreenGenericSpinner.vue @@ -62,38 +62,40 @@ onUnmounted(() => { diff --git a/src/components/KSkeleton/FullScreenKongSkeleton.vue b/src/components/KSkeleton/FullScreenKongSkeleton.vue index 0a77e25213..e29af8aa81 100644 --- a/src/components/KSkeleton/FullScreenKongSkeleton.vue +++ b/src/components/KSkeleton/FullScreenKongSkeleton.vue @@ -70,14 +70,14 @@ onUnmounted(() => { @include fullscreen-loading-container; .progress { - background-color: var(--KSkeletonFullScreenProgressBackgroundColor, var(--grey-200, color(grey-200))); - border-radius: 8px; - margin-top: 16px; + background-color: var(--KSkeletonFullScreenProgressBackgroundColor, var(--grey-200, var(--kui-color-background-neutral-weakest, $kui-color-background-neutral-weakest))); + border-radius: var(--kui-border-radius-40, kui-border-radius-40); + margin-top: var(--kui-space-60, $kui-space-60); max-width: 350px; .progress-bar { - background-color: var(--KSkeletonFullScreenProgressColor, var(--blue-500, color(blue-500))); - border-radius: 8px; + background-color: var(--KSkeletonFullScreenProgressColor, var(--blue-500, var(--kui-color-background-primary, $kui-color-background-primary))); + border-radius: var(--kui-border-radius-40, kui-border-radius-40); height: 5px; } } diff --git a/src/components/KSkeleton/KSkeleton.vue b/src/components/KSkeleton/KSkeleton.vue index 6e6e9736f4..63ea9954d9 100644 --- a/src/components/KSkeleton/KSkeleton.vue +++ b/src/components/KSkeleton/KSkeleton.vue @@ -1,8 +1,8 @@