Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated controller log print wording #1751

Closed
1 task done
mflendrich opened this issue Aug 25, 2021 · 0 comments · Fixed by #1755
Closed
1 task done

Fix generated controller log print wording #1751

mflendrich opened this issue Aug 25, 2021 · 0 comments · Fixed by #1755
Assignees
Labels
bug Something isn't working priority/low

Comments

@mflendrich
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

log.Info("updating the proxy with new {{.Type}}", "namespace", obj.Namespace, "name", obj.Name)

As @hbagdi pointed out, this extends to services and endpoints that have nothing to do with KIC. For example, the message below doesn't make much sense:

time="2021-08-20T22:07:05Z" level=info msg="updating the proxy with new Endpoints" CoreV1Endpoints="{\"Namespace\":\"local-path-storage\",\"Name\":\"rancher.io-local-path\"}" logger=controllers.Endpoints name=rancher.io-local-path namespace=local-path-storage

We should improve the wording to conduct the right message.

Expected Behavior

No response

Steps To Reproduce

No response

Kong Ingress Controller version

railgun

Kubernetes version

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants