From a8a046ea1749f600ce40d97abe7ca4d16115d3a0 Mon Sep 17 00:00:00 2001 From: Jay Wu Date: Mon, 11 Dec 2023 09:41:48 +0800 Subject: [PATCH] use --with-secure-transport to build libcurl on macos --- .github/workflows/build-and-release.yaml | 16 ++++++++-------- scripts/ci/build-libcurl.sh | 4 +++- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build-and-release.yaml b/.github/workflows/build-and-release.yaml index 4bc83063..0b55a02e 100644 --- a/.github/workflows/build-and-release.yaml +++ b/.github/workflows/build-and-release.yaml @@ -8,7 +8,7 @@ name: build-and-release on: push: tags: - - '*' + - "*" branches: - develop @@ -84,12 +84,12 @@ jobs: key: v4-${{ runner.os }}-libcurl-deps-cache-node-${{ matrix.node }}-fork restore-keys: | v4-${{ runner.os }}-libcurl-deps-cache-node-${{ matrix.node }}-fork - - name: 'Set GIT_TAG' + - name: "Set GIT_TAG" if: startsWith(github.ref, 'refs/tags') run: echo "GIT_TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV - - name: 'Publish Binary' + - name: "Publish Binary" run: | - GIT_COMMIT=${{ github.sha }} GIT_TAG=$GIT_TAG ./scripts/ci/build.sh + GIT_COMMIT=${{ github.sha }} GIT_TAG=$GIT_TAG RUNNER_OS=${{ runner.os }} ./scripts/ci/build.sh - name: Upload artifacts if: always() uses: actions/upload-artifact@v3 @@ -172,10 +172,10 @@ jobs: key: v4-${{ runner.os }}-libcurl-deps-cache-electron-${{ matrix.electron-version }}-fork restore-keys: | v4-${{ runner.os }}-libcurl-deps-cache-electron-${{ matrix.electron-version }}-fork - - name: 'Set GIT_TAG' + - name: "Set GIT_TAG" if: startsWith(github.ref, 'refs/tags') run: echo "GIT_TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV - - name: 'Publish Binary' + - name: "Publish Binary" run: | GIT_COMMIT=${{ github.sha }} GIT_TAG=$GIT_TAG ./scripts/ci/build.sh - name: Upload artifacts @@ -241,8 +241,8 @@ jobs: ELECTRON_VERSION: ${{ matrix.electron-version }} npm_config_msvs_version: 2022 npm_config_build_from_source: true - npm_config_runtime: 'electron' - npm_config_dist_url: 'https://electronjs.org/headers' + npm_config_runtime: "electron" + npm_config_dist_url: "https://electronjs.org/headers" npm_config_target: ${{ matrix.electron-version }} steps: - name: Checkout diff --git a/scripts/ci/build-libcurl.sh b/scripts/ci/build-libcurl.sh index f5c09094..0b268083 100755 --- a/scripts/ci/build-libcurl.sh +++ b/scripts/ci/build-libcurl.sh @@ -134,7 +134,9 @@ fi ##### # ssl #### -if [ ! -z "$OPENSSL_BUILD_FOLDER" ]; then +if [ "${RUNNER_OS}" == "macOS" ]; then + libcurl_args+=("--with-secure-transport") +elif [ ! -z "$OPENSSL_BUILD_FOLDER" ]; then CPPFLAGS="$CPPFLAGS -I$OPENSSL_BUILD_FOLDER/include" LDFLAGS="$LDFLAGS -L$OPENSSL_BUILD_FOLDER/lib -Wl,-rpath,$OPENSSL_BUILD_FOLDER/lib"