Update local observability stack steps #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-martin
force-pushed
the
local-observability-stack
branch
from
2eb4ff5
to
3154461
Compare
Signed-off-by: David Martin <davmarti@redhat.com>
david-martin
force-pushed
the
local-observability-stack
branch
from
3154461
to
04a5a8c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
==========================================
+ Coverage 80.20% 81.05% +0.84%
==========================================
Files 64 89 +25
Lines 4492 6899 +2407
==========================================
+ Hits 3603 5592 +1989
- Misses 600 886 +286
- Partials 289 421 +132
Flags with carried forward coverage won't be shown. Click here to find out more.
|
philbrookes
reviewed
Sep 30, 2024
philbrookes
approved these changes
Sep 30, 2024
Signed-off-by: David Martin <davmarti@redhat.com>
|
Thanks @philbrookes for finding the problems here and verifying the updated cmds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect at some point during the last batch of updates to the
quickstart-setup.shscript, changes were made to the observability kustomize config that meant the steps to install the stack separately (like after runningmake local-setup) no longer worked. 1 example of this is switching to a thanos datasource by default instead of prometheus (to allow for easier multicluster development & trialling locally).The changes in this PR update the observability README with the manual steps pulled from the
quickstart-setup.shscript to set up the observability stack, including example alerts & dashboards.