You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
I could create the high level API myself and submit it in a pull request but it would be useful to know if anybody else did this in another project that can be copied, if anybody else is already working on it, if you have ideas about how it should be developed, etc.
How to reproduce?
n/a
Expected & current behavior
Current behavior, from unit test:
client.sendRequest ("echo", params, ...
High-level API:
result = client.echo(params, ...
(Optional) Possible solution
There are two ways to go about this:
creating the high level API classes in the same repository, delivering them in the same library package, this appears to be the ideal approach to ensure API and ABI compatibility
Hello @dpocock! 👋 we're sorry you found a bug... so first of all, thank you very much for reporting it.
To know about progress, check in Triage. All issues are considered Backlog Candidates until work priorities align and the issue is selected for development. It will then become part of our official Backlog.
The kms-jsonrpc module is just a very thin adaptation layer over the jsoncpp library (of which Kurento maintains a fork). I'm not sure what is exactly done in it, because the module "Just Works ™" so it hasn't been touched for several years.
In any case I'm not sure of the usefulness of adding a sugar layer on top of sendRequest(). For one, KMS does never use this method (outside tests), because it only receives and processes requests, but doesn't send them. All the JSON-RPC clients in the project are those for Java, and JavaScript/Node.js platforms (and those are the ones sending requests to KMS).
It might have sense if you want to build applications on top of the Kurento Protocol, but otherwise I don't see Kurento (as project) benefiting from it. Maybe a bit more context might help me understand it better, what is the purpose of this proposed layer?
Prerequisites
These are MANDATORY, otherwise the issue will be automatically closed.
Issue description
kms-jsonrpc provides a low level way to handle JSON RPC messages from C++ code.
It would be very useful to have a higher level API, for example, with a C++ class or method representing each type of message.
Context
I am planning an open source integration from reSIProcate to Kurento
https://github.com/resiprocate/resiprocate/tree/master/apps/reConServer
I could create the high level API myself and submit it in a pull request but it would be useful to know if anybody else did this in another project that can be copied, if anybody else is already working on it, if you have ideas about how it should be developed, etc.
How to reproduce?
n/a
Expected & current behavior
Current behavior, from unit test:
High-level API:
(Optional) Possible solution
There are two ways to go about this:
Info about your environment
n/a
About Kurento Media Server
About your Application Server
About end-user clients
Run these commands
NA
The text was updated successfully, but these errors were encountered: