Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: default executor #11

Merged
merged 5 commits into from
Dec 11, 2023
Merged

[WIP] feat: default executor #11

merged 5 commits into from
Dec 11, 2023

Conversation

40lsgy1
Copy link
Collaborator

@40lsgy1 40lsgy1 commented Nov 30, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #12

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zoumo zoumo changed the title feat: default executor [WIP] feat: default executor Nov 30, 2023
pkg/utils/timeout.go Outdated Show resolved Hide resolved
pkg/utils/slice.go Outdated Show resolved Hide resolved
pkg/utils/slice.go Outdated Show resolved Hide resolved
pkg/utils/timeout.go Outdated Show resolved Hide resolved
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@jojohappy jojohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good, some suggestions remaining.

apis/rollout/v1alpha1/rollout_webhook_types.go Outdated Show resolved Hide resolved
pkg/controllers/rolloutrun/executor/default.go Outdated Show resolved Hide resolved
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
pkg/webhook/webhook.go Show resolved Hide resolved
pkg/webhook/webhook.go Show resolved Hide resolved
pkg/webhook/webhook.go Show resolved Hide resolved
pkg/webhook/webhook.go Show resolved Hide resolved
pkg/utils/slice.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Wenfeng-GAO Wenfeng-GAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jojohappy jojohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@40lsgy1 40lsgy1 enabled auto-merge (squash) December 11, 2023 11:13
fix some bugs
@40lsgy1 40lsgy1 merged commit 7cd34b5 into main Dec 11, 2023
@40lsgy1 40lsgy1 deleted the default_executor branch December 11, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: add new process engine to replace workflow
4 participants