Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for nr.dmnd and nr.gz #221

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Conversation

chasemc
Copy link
Member

@chasemc chasemc commented Jan 19, 2022

if params.large_downloads_permission = false and nr.gz existed but nr.dmnd didnlt the pipeline would fail.
This...
// check for nr.dmnd, if not found, check for nr.gz
// if nr.gz exists, create nr.dmnd
// if nr.gz also doesn't exist, stop the pipeline

if `params.large_downloads_permission = false` and nr.gz existed but nr.dmnd the pipeline would fail.
This...
            // check for nr.dmnd, if not found, check for nr.gz
            // if nr.gz exists, create nr.dmnd
            // if nr.gz also doesn't exist, stop the pipeline
// check for nr.dmnd, if not found, check for nr.gz
// if nr.gz exists, create nr.dmnd
// if nr.gz also doesn't exist, stop the pipeline
if (!file("${params.nr_dmnd_dir}/nr.dmnd").exists()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the diamond_db channel also need to be set within an else statement for when nr.dmnd exists?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, fixed

Copy link
Collaborator

@evanroyrees evanroyrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evanroyrees evanroyrees merged commit 325172e into dev Jan 19, 2022
@evanroyrees evanroyrees deleted the chasemc-patch-check-for-nr branch January 19, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants