Also rename nested column fields if they exist #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a thought, has not been tested throughly.
sean185
commented
Jan 8, 2020
utils/dbmaint.q
Outdated
| @@ -66,7 +66,10 @@ reordercols0:{[tabledir;neworder] | |||
| rename1col:{[tabledir;oldname;newname] | |||
| if[(oldname in ac)and not newname in ac:allcols tabledir; | |||
| stdout"renaming ",(string oldname)," to ",(string newname)," in `",string tabledir; | |||
| .os.ren[` sv tabledir,oldname;` sv tabledir,newname];@[tabledir;`.d;:;.[ac;where ac=oldname;:;newname]]]} | |||
| .os.ren[` sv tabledir,oldname;` sv tabledir,newname]; | |||
| if[key ` sv tabledir,oldname1:`$(string oldname),"#"; | |||
There was a problem hiding this comment.
This fails as the condition checks on a sym type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a thought, has not been tested throughly.