Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also rename nested column fields if they exist #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion utils/dbmaint.q
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ reordercols0:{[tabledir;neworder]
rename1col:{[tabledir;oldname;newname]
if[(oldname in ac)and not newname in ac:allcols tabledir;
stdout"renaming ",(string oldname)," to ",(string newname)," in `",string tabledir;
.os.ren[` sv tabledir,oldname;` sv tabledir,newname];@[tabledir;`.d;:;.[ac;where ac=oldname;:;newname]]]}
.os.ren[` sv tabledir,oldname;` sv tabledir,newname];
if[key ` sv tabledir,oldname1:`$(string oldname),"#";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails as the condition checks on a sym type.

.os.ren[` sv tabledir,oldname1;` sv tabledir,`$(string newname),"#"]];
@[tabledir;`.d;:;.[ac;where ac=oldname;:;newname]]]}

ren1table:{[old;new]stdout"renaming ",(string old)," to ",string new;.os.ren[old;new];}

Expand Down