Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeReaction! etc. doesn't update all fields in a CoreModel #768

Open
htpusa opened this issue Feb 27, 2023 · 1 comment
Open

removeReaction! etc. doesn't update all fields in a CoreModel #768

htpusa opened this issue Feb 27, 2023 · 1 comment
Assignees
@exaexa @htpusa
Labels
bug Something isn't working
Milestone
v1.5.x

Comments

@htpusa
Copy link
Collaborator

htpusa commented Feb 27, 2023 

using COBREXA
model = load_model(CoreModel,"test/downloaded/e_coli_core.xml")
removeReaction!(model,1)
n_reactions(model) # 94
length(model.grrs) # 95

Only some of the fields are updated so, for example, the gene associations end up not matching anymore.
@exaexa
Copy link
Collaborator

exaexa commented Feb 28, 2023

ah this. We added grrs later so this is an avoidable but kinda expected bug. Thanks for report

@exaexa exaexa added the bug Something isn't working label Feb 28, 2023
@exaexa exaexa added this to the v1.5 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exaexa exaexa

@htpusa htpusa

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.5.x
Development

No branches or pull requests
2 participants
@exaexa @htpusa