Add resource to RAJA variants #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhornung67
changed the title
MrBurmark
reviewed
Oct 31, 2024
Comment on lines
+68
to
+73
| RAJA::kernel_resource<EXEC_POL>( | ||
| RAJA::make_tuple(RAJA::RangeSegment(0, num_d), | ||
| RAJA::RangeSegment(0, num_z), | ||
| RAJA::RangeSegment(0, num_g), | ||
| RAJA::RangeSegment(0, num_m)), | ||
| res, |
There was a problem hiding this comment.
The indentation here is not consistent with the others. I kind of like it, but it is the odd one out.
There was a problem hiding this comment.
I did it that way to avoid line wrapping in an 80 column window.
There was a problem hiding this comment.
We should probably ultimately indent them all this way for consistency.
MrBurmark
approved these changes
Oct 31, 2024
adayton1
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary