Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for GitHub API missing Status header. #57

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Fix for GitHub API missing Status header. #57

merged 2 commits into from
Feb 6, 2021

Conversation

LRWeber
Copy link
Member

@LRWeber LRWeber commented Feb 5, 2021 •
edited
Loading

GitHub queryManager's response handling no longer relies on the response headers for HTTP status information.
Also fixes Travis CI failure due to markdownlint-cli bug.

@LRWeber LRWeber added the bug label Feb 5, 2021
@LRWeber LRWeber marked this pull request as draft February 5, 2021 23:04
@LRWeber LRWeber marked this pull request as ready for review February 5, 2021 23:05
IanLee1521
IanLee1521 approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@IanLee1521 IanLee1521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although I'll admit I haven't specifically tested it. I'm just going to assume that it works functionally for us (or there will be another PR :) )

@IanLee1521 IanLee1521 merged commit 559e5ba into main Feb 6, 2021
@IanLee1521 IanLee1521 deleted the github-header-fix branch February 6, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanLee1521 IanLee1521 IanLee1521 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LRWeber @IanLee1521