Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Use payment probing to improve fee estimate #3160

Merged
merged 26 commits into from
Mar 29, 2020

Conversation

mrfelton
Copy link
Member

@mrfelton mrfelton commented Nov 11, 2019

Description:

And implementation of payment probing.

Implements the recommendations from LL to use payment probing in order to determine an accurate fee estimate along a routable path.

Payment probing will only be used for lnd nodes on version 0.7.1 and above as it requires improved error handing provided by the new Router api.

See lightningnetwork/lnd#2537 for context.

Motivation and Context:

Improve fee estimate accuracy.

How Has This Been Tested?

Manually

Types of changes:

Enhancement

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton self-assigned this Nov 11, 2019
@mrfelton mrfelton requested a review from korhaliv November 11, 2019 09:10
@mrfelton mrfelton added the type: enhancement New feature or request label Nov 11, 2019
@korhaliv korhaliv changed the title Uue payment probing to improve fee estimate Use payment probing to improve fee estimate Nov 11, 2019
@mrfelton mrfelton force-pushed the feat/payment-probes branch 5 times, most recently from e508097 to 645180a Compare November 12, 2019 10:54
@coveralls
Copy link

coveralls commented Nov 12, 2019

Coverage Status

Coverage decreased (-0.1%) to 22.331% when pulling 5fbd43a on mrfelton:feat/payment-probes into 698f465 on LN-Zap:next.

@mrfelton mrfelton added this to the v0.6.0-beta milestone Nov 12, 2019
@mrfelton mrfelton force-pushed the feat/payment-probes branch from 88b3549 to cb75295 Compare November 12, 2019 21:07
@mrfelton mrfelton modified the milestones: v0.6.0-beta, v0.6.1-beta Nov 14, 2019
@mrfelton mrfelton added the status: blocked issues with blockers that we can't currently get past label Nov 15, 2019
@mrfelton mrfelton modified the milestones: v0.6.3-beta, v0.7.0-beta Dec 15, 2019
@mrfelton mrfelton force-pushed the feat/payment-probes branch from bf01021 to 9e69008 Compare December 16, 2019 08:09
@mrfelton mrfelton removed the status: blocked issues with blockers that we can't currently get past label Dec 16, 2019
@mrfelton mrfelton changed the base branch from master to next December 16, 2019 14:59
@mrfelton mrfelton force-pushed the feat/payment-probes branch from 9e69008 to 0d9685d Compare December 16, 2019 14:59
@mrfelton mrfelton force-pushed the feat/payment-probes branch from 0d9685d to 36370d0 Compare March 24, 2020 14:09
@mrfelton mrfelton force-pushed the feat/payment-probes branch from 854d543 to acf8582 Compare March 29, 2020 06:58
@mrfelton mrfelton force-pushed the feat/payment-probes branch from 6fe052b to 5fbd43a Compare March 29, 2020 09:21
@mrfelton mrfelton merged commit 5ed7dda into LN-Zap:next Mar 29, 2020
@mrfelton mrfelton deleted the feat/payment-probes branch March 29, 2020 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants