Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/use id for errors #84

Merged

Conversation

andreyyudin
Copy link
Contributor

This is a fix of field ids being ignored when the anchor link to the field in the error summary section is being rendered. Originally the link has been pointing to the field by the name of the Python attribute of the form, rather than by the id parameter of the attribute.

andreyyudin and others added 3 commits October 18, 2023 17:33
rendered if the description field has not been set
…ided ids. Othewise, the rendered clickable error would not shift the screen to the correct HTML anchor.
@matthew-shaw matthew-shaw self-assigned this Feb 13, 2024
@matthew-shaw matthew-shaw added the bug Something isn't working label Feb 13, 2024
@matthew-shaw matthew-shaw changed the base branch from main to bugfix February 13, 2024 10:44
@matthew-shaw matthew-shaw merged commit 34373aa into LandRegistry:bugfix Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants