Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@sortBy nulls ordering (config) #111

Merged
merged 22 commits into from
Jan 8, 2024
Merged

@sortBy nulls ordering (config) #111

merged 22 commits into from
Jan 8, 2024

Conversation

LastDragon-ru
Copy link
Owner

Issue: #110

@LastDragon-ru
AstManipulator::addTypeDefinition() will support registration of `G…
0b11584 
…raphQL\Type\Definition\PhpEnumType` (through custom scalar and `Nuwave\Lighthouse\Support\Contracts\TypeResolver` directive).
@LastDragon-ru
SearchByTypeFlag/SortByTypeFlag converted into php enum.
9163d94
@LastDragon-ru
deprecate(graphql): enum SearchByTypeFlag { yes }/`enum SortByTypeF…
75639af 
…lag { yes }`, please use `enum SearchByTypeFlag { Yes }`/`enum SortByTypeFlag { Yes }` instead.
@LastDragon-ru
SortByTypeDirection converted into php enum.
6b4c93d
@LastDragon-ru
deprecate(graphql/@sortby): enum SortByTypeDirection { asc, desc },…
c9a515b 
… please use `enum SortByTypeDirection { Asc, Desc }` instead.
@LastDragon-ru
Added interface Sorter.
247fbe8
@LastDragon-ru
Sorters rename.
148e79d
@LastDragon-ru
Code cleanup.
0f1f256
@LastDragon-ru
TypeDefinition contract improvements.
f05e3ba
@LastDragon-ru
Initial NULL behavior support.
9d1eb50
@LastDragon-ru
Config adapted to be able to use different processing for each direct…
cf01deb 
…ion.
@LastDragon-ru
Direction moved to directive root namespace.
f5261a9
@LastDragon-ru
PHPStan v1.10.54
81a8583
@LastDragon-ru
Added Sorter and SorterFactory contracts.
0be3ae7
@LastDragon-ru
perf(graphql): Bindings registration (bindIf() => scopedIf()).
41387ae
@LastDragon-ru
Nulls will use First and Last cases.
8257b03
@LastDragon-ru
Enums moved to separate namespace.
231d96d
@LastDragon-ru
Added Sorter::isNullsSortable(), Field will pass nulls to `sort…
76b6357 
…()`.
@LastDragon-ru
NULL FIRST/NULL LAST implementation.
bab2f25
@LastDragon-ru
Fixes and more tests.
5cf6ca8
@LastDragon-ru
Sorter::isNullsSortable() => Sorter::isNullsSupported().
01b06e0
@LastDragon-ru
Documentation.
72f940b
@LastDragon-ru LastDragon-ru added scope: feat New feature or request pkg: graphql ! Breaking change labels Jan 8, 2024
@LastDragon-ru LastDragon-ru added this to the Next milestone Jan 8, 2024
@LastDragon-ru LastDragon-ru self-assigned this Jan 8, 2024
@LastDragon-ru LastDragon-ru mentioned this pull request Jan 8, 2024
Closed
2 tasks
@LastDragon-ru LastDragon-ru linked an issue Jan 8, 2024 that may be closed by this pull request
@sortBy: Nulls ordering (NULLS FIRST/NULLS LAST) #110
Closed
2 tasks
@LastDragon-ru LastDragon-ru removed a link to an issue Jan 8, 2024
@sortBy: Nulls ordering (NULLS FIRST/NULLS LAST) #110
Closed
2 tasks
@LastDragon-ru LastDragon-ru merged commit e528aec into main Jan 8, 2024
74 checks passed
@LastDragon-ru LastDragon-ru deleted the graphql/sortByNullsOrdering branch January 8, 2024 09:23
@LastDragon-ru LastDragon-ru linked an issue Jan 8, 2024 that may be closed by this pull request
@sortBy: Nulls ordering (NULLS FIRST/NULLS LAST) #110
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LastDragon-ru LastDragon-ru

Labels
! Breaking change pkg: graphql scope: feat New feature or request
Projects
None yet
Milestone
6.x
Development

Successfully merging this pull request may close these issues.

@sortBy: Nulls ordering (NULLS FIRST/NULLS LAST)
1 participant
@LastDragon-ru