New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the torch-sys build script. #703

Merged

LaurentMazare merged 3 commits into main from rework-build-script

May 13, 2023

Owner

LaurentMazare commented May 13, 2023 •

edited

Loading

This PR reworks the torch-sys build script:

It ensures that the rpath bit gets properly propagated to dependent crates, with this setting LD_LIBRARY_PATH should not be necessary anymore.
Add supports for linking with a python PyTorch version that gets found and setup via the python command line.
Clean-up the way to access the OS information.

Tested:

Using a local install via LIBTORCH.
Using a PyTorch install via LIBTORCH_USE_PYTORCH=1.

LaurentMazare added 3 commits

May 13, 2023 09:18


          Rework the build script.

1c9891a


          Update the readme.


          Add some version check.

abcc7b8

LaurentMazare merged commit 50803c7 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet