Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+8 icons, +1 link, +4 updates #1865

Merged
merged 12 commits into from
Mar 2, 2024
Merged

+8 icons, +1 link, +4 updates #1865

merged 12 commits into from
Mar 2, 2024

Conversation

SK00RUPA
Copy link
Contributor

@SK00RUPA SK00RUPA commented Feb 29, 2024

Description

Added few new icons and updated Athena icon to better reflect the original one.

Icons addition information

Added

ColorBlendr (com.drdisagree.colorblendr)
DevInfoOverlay (ru.andr7e.devinfooverlay)
File Navigator (com.w2sv.filenavigator)
HeliBoard (helium314.keyboard)
Kraken (com.kraken.invest.app)
Kraken Pro (com.kraken.trade)
Rozkład PKP (de.hafas.android.pkp)
Sim Cell Info (ru.andr7e.simcellinfo)

Linked

Wi-Fi Monitor (ru.andr7e.wifimonitorwifianalyzer.svg)

Updated

Athena (dev.sebaubuntu.athena)
Florisboard (dev.patrickgold.florisboard[.beta/.debug])
Gboard (com.google.android.inputmethod.latin)
OpenBoard (org.dslul.openboard.inputmethod.latin)

Contributor's checklist

  • I made the icons following the Lawnicons Guidelines (upd. Jan 2024) and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.

svgs/colorblendr.svg Show resolved Hide resolved
svgs/dev_info_overlay.svg Show resolved Hide resolved
svgs/heliboard.svg Show resolved Hide resolved
svgs/sim_cell_info.svg Show resolved Hide resolved
svgs/athena.svg Show resolved Hide resolved
@x9136 x9136 added rework The team has requested changes in the issue or PR. icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. labels Mar 2, 2024
@SK00RUPA
Copy link
Contributor Author

SK00RUPA commented Mar 2, 2024

Thanks for the review, I applied your suggestions.

If you want to make such a change, then you should do it within the guidelines. There is no 2px stroke width.

About the Athena icon, I didn't manage to find a way to make only the bottom part of the "phone" 14px and the rest 12px.
I changed that 2px stroke to 8px to stay within the guidelines, but if you have a better idea how to achieve that I would be grateful for the hint.

Lastly, I added one more icon, taking the opportunity that this PR wasn't merged right in.

@SK00RUPA SK00RUPA changed the title +7 icons, +1 link, +1 update +8 icons, +1 link, +1 update Mar 2, 2024
svgs/dev_info_overlay.svg Show resolved Hide resolved
svgs/heliboard.svg Show resolved Hide resolved
@x9136
Copy link
Collaborator

x9136 commented Mar 2, 2024

but if you have a better idea how to achieve that I would be grateful for the hint.

I can't help you with that.

@SK00RUPA SK00RUPA changed the title +8 icons, +1 link, +1 update +8 icons, +1 link, +4 updates Mar 2, 2024
@x9136
Copy link
Collaborator

x9136 commented Mar 2, 2024

Cool, thanks!

@x9136 x9136 merged commit 424c31d into LawnchairLauncher:develop Mar 2, 2024
4 checks passed
@SK00RUPA SK00RUPA deleted the new branch March 2, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants