Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗞️ Add composer swap examples #1097

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

🗞️ Add composer swap examples #1097

wants to merge 14 commits into from

Conversation

St0rmBr3w
Copy link
Contributor

No description provided.

@St0rmBr3w St0rmBr3w changed the title feat: added UniswapV3Composer example 🗞️ Add composer swap examples Dec 11, 2024
@ryandgoulding
Copy link
Contributor

Although this is super cool, there is a lot of custom solidity code. I would recommend this is audited before adding it as an example. Maybe we can combine it with other examples work to save some cycles.

@St0rmBr3w
Copy link
Contributor Author

Although this is super cool, there is a lot of custom solidity code. I would recommend this is audited before adding it as an example. Maybe we can combine it with other examples work to save some cycles.

Yep, the idea would be to get this audited with any other composer examples we want.

Riley mentioned staking, but this really only applies to native assets so Uniswap is the only example we have at the moment.

Do you have any ideas for improving?

Copy link

socket-security bot commented Dec 13, 2024

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Unpopular package npm/@layerzerolabs/test-devtools-evm-foundry@5.1.0 ⚠︎

View full report↗︎

Next steps

What are unpopular packages?

This package is not very popular.

Unpopular packages may have less maintenance and contain other problems.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@layerzerolabs/test-devtools-evm-foundry@5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants