Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headers for routing on encoding streamer #765

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Add headers for routing on encoding streamer #765

merged 1 commit into from
Sep 20, 2024

Conversation

dmanc
Copy link
Contributor

@dmanc dmanc commented Sep 18, 2024

Why are these changes needed?

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@dmanc dmanc marked this pull request as ready for review September 19, 2024 05:40
jianoaix
jianoaix approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a nice as it's quite lightweight in code

@dmanc dmanc merged commit 09c300e into Layr-Labs:master Sep 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@pschork pschork pschork approved these changes

@bxue-l2 bxue-l2 Awaiting requested review from bxue-l2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmanc @pschork @jianoaix