Skip to content

Commit

Permalink
Revert "Add "autocomplete" as initialization option (#17159)"
Browse files Browse the repository at this point in the history
This reverts commit 9896781.
  • Loading branch information
LeaVerou committed Sep 21, 2018
1 parent 9896781 commit d6df8a5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion awesomplete.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ var _ = function (input, o) {
this.isOpened = false;

this.input = $(input);
this.input.setAttribute("autocomplete", "awesomplete");
this.input.setAttribute("autocomplete", "off");
this.input.setAttribute("aria-owns", "awesomplete_list_" + this.count);
this.input.setAttribute("role", "combobox");

Expand Down
2 changes: 1 addition & 1 deletion test/init/htmlSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ describe("Html modifications", function () {
});

it("turns native autocompleter off", function () {
expect(this.subject.input.getAttribute("autocomplete")).toBe("awesomplete");
expect(this.subject.input.getAttribute("autocomplete")).toBe("off");
});

describe("HTML tweaks", function () {
Expand Down

2 comments on commit d6df8a5

@vespoli
Copy link

@vespoli vespoli commented on d6df8a5 Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - This change is not updated in an npm pull or on the cdn version

Edit: Duh, sorry this change happened after the latest release. Any possibility we could get a release bump with this update? :)

@NattyBumppo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vespoli Looks like the release is updated now.

Please sign in to comment.