Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding latlng-creation in GeoJSON.js. #888

Closed
wants to merge 1 commit into from
Closed

Support overriding latlng-creation in GeoJSON.js. #888

wants to merge 1 commit into from

Conversation

mattiasb
Copy link
Contributor

@mattiasb mattiasb commented Aug 8, 2012

Add support for overriding the latlng-creation with a custom factory method in GeoJSON.js.
Use case includes reprojecting the coordinates (for example by
reacting to the crs-field in the geojson spec).

This is one possible way of Issue #866. Really not sure if this is a good way or not though.

method in GeoJSON.js.
Use case includes reprojecting the coordinates (for example by
reacting to the crs-field in the geojson spec).
@mattiasb
Copy link
Contributor Author

mattiasb commented Aug 8, 2012

Example usage of this can be found here.

@mourner
Copy link
Member

mourner commented Sep 25, 2012

Hey Mattias, sorry for not getting to this for so long, I had too much stuff to deal with last month (vacation trips, other work, etc.), I'll definitely look close into this issue as a part of projections code refactoring in the next week (when I'm back to Kiev).

@mattiasb
Copy link
Contributor Author

No problem! :)
Poke me if you want to discuss this further, preferrably on IRC.

@kengu
Copy link

kengu commented Sep 25, 2012

Hi @mourner,

could you please also look at #945, another projection-releated issue?

@mourner
Copy link
Member

mourner commented Sep 25, 2012

Sure! I keep an eye on all pulls, just don't always look into it deeply soon enough (especially when it is related to some code that is undergoing refactoring).

@kengu
Copy link

kengu commented Sep 25, 2012

@mourner: Thanks!

@mourner mourner closed this in 96748cd Apr 20, 2013
@mourner
Copy link
Member

mourner commented Apr 20, 2013

Mattias, I took your idea, modified it a bit and put the changes in manually. Basically you just pass coordsToLatLng as an option and it handles everything.

I also removed the reverse argument which only made sense out of GeoJSON context and not used anywhere.

@mourner
Copy link
Member

mourner commented Apr 20, 2013

Please check if it works for your case!

@mattiasb
Copy link
Contributor Author

Yay! Will try this as soon as I get the chance!
Den 20 apr 2013 14:49 skrev "Vladimir Agafonkin" notifications@github.com:

Please check if it works for your case!


Reply to this email directly or view it on GitHubhttps://github.com//pull/888#issuecomment-16703507
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants