Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate save-always #40

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Deprecate save-always #40

merged 2 commits into from
Oct 30, 2024

Conversation

BD103
Copy link
Collaborator

@BD103 BD103 commented Oct 30, 2024

Fixes #37.

actions/cache's save-always input has been deprecated, with the only workaround being calling actions/cache/save at the end of a job. Because we cannot run post steps as a composite action, we can no longer support save-always's behavior.

This PR deprecates save-always in the same way cache-cargo-sweep is deprecated. Though this is technically a breaking change because some large repositories could be relying on a cache always being created, I think this is still safe to publish in v2.5.0.

@BD103 BD103 added the bug Something isn't working label Oct 30, 2024
@BD103 BD103 requested a review from TimJentzsch October 30, 2024 22:17
@BD103 BD103 merged commit 5b068d2 into main Oct 30, 2024
3 checks passed
@BD103 BD103 deleted the save-always-deprecation branch October 30, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input 'save-always' has been deprecated
2 participants