Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use InputMap as an asset #423

Closed
barsoosayque opened this issue Dec 9, 2023 · 3 comments · Fixed by #426
Closed

Unable to use InputMap as an asset #423

barsoosayque opened this issue Dec 9, 2023 · 3 comments · Fixed by #426
Labels
bug Something isn't working

Comments

@barsoosayque
Copy link
Contributor

Version

0.11.2

Operating system & version

NixOS (master)

What you did

Updating to bevy 0.12 / leafwing-input-manager 0.11.2

What you expected to happen

Handle<InputMap<A>> generates no errors, as it was valid before to use InputMap as an asset.

What actually happened

My code that used InputMap<A> as an asset (e.g. Handle<InputMap<A>>) is not working anymore.

Additional information

Apparently assets now should derive Asset instead of TypeUuid, and although it is a simple change, it unravels an issue I tried to fix in #386, because Asset requires TypePath, which can be provided by Reflect. And even though version 0.11 mentions that InputMap should be Reflect now, as far as I can tell it's not ?

@barsoosayque barsoosayque added the bug Something isn't working label Dec 9, 2023
@alice-i-cecile
Copy link
Contributor

Thanks for the report! And yeah, the latest 0.11 version is a bit screwed up. I'll take a look!

@barsoosayque
Copy link
Contributor Author

What would be the best course of action here ? I might reopen and port to multimap #386, if that is a good solution ? I would be glad to work on this and resolve it asap but I'm not sure what to actually do

@alice-i-cecile
Copy link
Contributor

Yep, redoing the change in #386 on the latest main is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants