-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Reflect for InputMap #386
Conversation
Can you swap this to a Ideally we do the same thing for all of our component and resource types actually, but that doesn't have to be this PR. |
Sure thing. Didn't know |
So since |
Right, okay :) Let's merge this as is then. |
Head branch was pushed to by a user without write access
Um. so this PR is pretty much the same as #331 (although it's slightly outdated). And I've seen that there is an ongoing work to remove a |
We should merge this and unblock this feature request, then remove PetitSet in another PR. |
Head branch was pushed to by a user without write access
b737a22
to
8ef394d
Compare
8ef394d
to
681ec56
Compare
I'm going to tackle this in #400, which should be done shortly :) This was super helpful to push me towards "remove petitset" as the right architectural decision, thank you. |
* Fix typo * Update release notes * Straightforward migration * Remove useless test for from impl * Just use a Vec for chords :( * Clone because our API is jank * Hash all the types * Repair tests after swapping to a Vec * Simple fixes for binding_map * Remove binding_menu egui example due to maintenance burden * Clippy * Fix idempotency of insertion * Remove brittle serde test * Simple doc test fixes * Remove outdated references to 16 max input maps * Implement Reflect for InputMap Closes #386. * Reflect UserInput Closes #331 * Simple fix for doc test * Fix mismatched HashMap types in doc test * Remove example using removed API * Switch `A::variants()` to `self.iter()` (#411) * Update for Bevy 0.12 (#408) * Update to git * forgot a configure_set * Update examples * Update Bevy to 0.12 release * Bump versions * Disable failing test * Remove bevy_egui so we can ship * Update release notes --------- Co-authored-by: Tomato <67799071+100-TomatoJuice@users.noreply.github.com> Co-authored-by: Alice Cecile <alice.i.cecil@gmail.com> * Add back `bevy_egui` to LWIM 0.11 (#409) * Update to `bevy_egui` 0.23 for Bevy 0.12 * Bump to 0.11.1 * Update RELEASES.md * Switch `A::variants()` to `self.iter()` --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Alice Cecile <alice.i.cecil@gmail.com> --------- Co-authored-by: Tomato <67799071+100-TomatoJuice@users.noreply.github.com> Co-authored-by: Alice Cecile <alice.i.cecil@gmail.com>
Currently it's not possible to directly use an
InputMap<A>
as an asset (e.g.Handle<InputMap<A>>
), astrait Asset
now requiresTypePath
.