Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App 0.8.6 Update #11

Merged
merged 36 commits into from
Sep 15, 2023
Merged

App 0.8.6 Update #11

merged 36 commits into from
Sep 15, 2023

Conversation

shufps
Copy link

@shufps shufps commented Jul 26, 2023 •
edited by xchapron-ledger
Loading

changes on the app:

  • changed value format to decimals for Stardust protocol
  • fixed small UI paging bug (see comment in the code)
  • replaced the I logo with the official IOTA logo
  • bumped app version to 0.8.6

changes connected to the enforce Ledger guidelines github workflows:

  • replace code using obsolete fuctions (cx_*)
  • fixed complaints by static analyzer (shadowed global variables, buffer with size depending on a input variable)
  • removed alpha-channel from gif images

changes on the Makefile:

  • removed --apiLevel 1 parameter for nanosplus because loading always failed.

changes in build.sh:

  • removed -it from docker run because it prevented to use the simulator in Github CI (because there is not TTY)
  • added flag to start the simulator detached / in background for Github CI

shufps and others added 27 commits March 17, 2023 17:57
@shufps
added changes to makefile to remove the --apiLevel 1 parameter on `ma…
d7ad3e7 
…ke load` for nanosplus
@shufps
removed -it flag. It prevents starting the simulator in github CI e…
60a79cc 
…nvironment because there is no TTY
@shufps
added -b flag to start simulator in detached / background mode
8c287e6
@shufps
Merge pull request #45 from iotaledger/fix/build-without-it-flag
31a6ee9 
removed `-it` flag and added parameter for starting the simulator detached
@shufps
Makefile: Fix listvariants placeholder
f0fe452
@shufps
Bump version to 0.8.5
e8be148
@shufps
changed iota + stardust to decimal values and bumped app version to 0…
b93f55f 
….8.6
@shufps
fixed linter error
f70179f
@shufps
Merge pull request #47 from iotaledger/feat/decimals-for-iota-stardust
c452112 
changed iota + stardust to decimal values and bumped app version to 0.8.6
@shufps
Merge branch 'develop' into develop
4430269
@shufps
.github: Use reusable workflow from Ledger
f5986c8
@shufps
Merge branch 'develop' of ssh://github.com/iotaledger/ledger-iota-app…
337b45e 
… into develop
@shufps
fixed shadowed variable error; fixed deprecates (cx_blake2b_init an…
43fd3c5 
…d `cx_hash`)
@shufps
fixed obsoletes.
a85addd
@shufps
fixed "shadowed variable" complaints
72f8955
@shufps
fixing linter
f8c42da
@shufps
changed icon for iota app back to iota logo
2ece4b7
@shufps
removed variable buffer size and replaced it with constant
948c2a0
@shufps
some cosmetics. Use MUST() instead of ifs on some places
7e42ad5
@shufps
fixed linter error
3e28e94
@shufps
removed alpha channel of 2bit gifs
79836eb
@shufps
removed alpha channel of all icons
c348126
@shufps
removed "false-positive" glyph that wasn't used anyways
ff93c6e
@shufps
replaced iota icon with iota logo
489bf3f
@shufps
fixed small UI paging issue with a simple workaround
e089aa3
@shufps
Merge pull request #48 from iotaledger/chore/guidelines-compliance
18ceb06 
fixed guideline-compliance
@shufps
Merge pull request #49 from iotaledger/fix/makefile-load-nanosplus
092924e 
added changes to makefile
xchapron-ledger
xchapron-ledger reviewed Sep 12, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
xchapron-ledger
xchapron-ledger reviewed Sep 12, 2023
View reviewed changes
src/iota/ed25519.c Outdated Show resolved Hide resolved
xchapron-ledger
xchapron-ledger reviewed Sep 13, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
src/iota/address.c Show resolved Hide resolved
src/iota/ed25519.c Outdated Show resolved Hide resolved
src/iota/ed25519.h Outdated Show resolved Hide resolved
src/iota/signing.c Show resolved Hide resolved
src/iota/signing.c Show resolved Hide resolved
@shufps
removed unneeded include path in Makefile and added const on ed2551…
5ddacb5 
…9_public_key_to_bytes
@shufps
linter
eba8048
@shufps
Merge pull request #54 from iotaledger/feat/use-crypto-helpers
0481606 
removed unneeded include path in Makefile and added `const` on ed2551…
xchapron-ledger
xchapron-ledger reviewed Sep 15, 2023
View reviewed changes
glyphs/icon_back.gif
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many glyphs could be dropped as already present in the SDK: https://github.com/LedgerHQ/ledger-secure-sdk/tree/master/lib_ux/glyphs

src/iota/address.c Show resolved Hide resolved
src/iota/signing.c Show resolved Hide resolved
src/iota/signing.c Show resolved Hide resolved
@xchapron-ledger
Copy link

Linked to https://ledgerhq.atlassian.net/browse/B2CA-1382

@xchapron-ledger xchapron-ledger merged commit 840709b into LedgerHQ:develop Sep 15, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xchapron-ledger xchapron-ledger xchapron-ledger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shufps @xchapron-ledger