New Release

[overcat]

Checklist

• App update process has been followed
• Target branch is develop
• Application version has been bumped

You can find the changelog here.

Resolve #82

[ledger-wiz-cspm-secret-detection]

Wiz Scan Summary

IaC Misconfigurations
Sensitive Data
Total
Secrets

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 87.81955% with 162 lines in your changes are missing coverage. Please review.

Project coverage is 89.34%. Comparing base (3d5896b) to head (e9ca974).

Files	Patch %	Lines
libstellar/parser.c	89.70%	83 Missing ⚠️
libstellar/printer.c	84.61%	78 Missing ⚠️
libstellar/base64.c	94.11%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           develop      #84       +/-   ##
============================================
+ Coverage    76.87%   89.34%   +12.47%     
============================================
  Files           14        5        -9     
  Lines         2378     2676      +298     
============================================
+ Hits          1828     2391      +563     
+ Misses         550      285      -265     

Flag	Coverage Δ
unittests	89.34% <87.81%> (+12.47%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[overcat]

Perhaps we need to disable the default CodeQL scan configuration. Otherwise, the CodeQL CI will not pass.

https://docs.github.com/en/code-security/code-scanning/troubleshooting-sarif-uploads/default-setup-enabled

[tdejoigny-ledger]

Hello @overcat , ty for your PR

Could you please open a PR to update the ledger database (https://github.com/LedgerHQ/ledger-app-database) for Stellar in order to have the guideline CI green ?
Is there any test for the new device ? I didn't find any snapshots..
Last remark, you can probably:

• use useCaseHomeAndSettings instead of useCaseHome + useCaseSettings
• use useCaseAddressReview instead of nbgl_useCaseReviewStart + nbgl_useCaseAddressConfirmation

We have a good example in our boilerplate app. It would be more simple & easier to maintain (with the guarantee to be aligned with the design guidelines)

[overcat]

Hi @tdejoigny-ledger

Could you please open a PR to update the ledger database (https://github.com/LedgerHQ/ledger-app-database) for Stellar in order to have the guideline CI green ?

I added it a few days ago, and now CI has passed.

Is there any test for the new device ? I didn't find any snapshots.

We use zemu for e2e testing, but it does not yet support Flex, so we may need to wait some time before adding it.
The other four devices all have end-to-end testing.

Last remark, you can probably:
use useCaseHomeAndSettings instead of useCaseHome + useCaseSettings
use useCaseAddressReview instead of nbgl_useCaseReviewStart + nbgl_useCaseAddressConfirmation
We have a good example in our boilerplate app. It would be more simple & easier to maintain (with the guarantee to be aligned with the design guidelines)

I have made the corresponding modifications. Because I also want to make some changes in the UI aspect, originally I planned to submit them together at that time, but now let's first submit this part.

CodeQL test failure is likely due to repository configuration issues: #84 (comment), it is running well in my repository: https://github.com/lightsail-network/app-stellar/actions/runs/9869736057

[tdejoigny-ledger]

Hi @tdejoigny-ledger

Could you please open a PR to update the ledger database (https://github.com/LedgerHQ/ledger-app-database) for Stellar in order to have the guideline CI green ?

I added it a few days ago, and now CI has passed.

Is there any test for the new device ? I didn't find any snapshots.

We use zemu for e2e testing, but it does not yet support Flex, so we may need to wait some time before adding it. The other four devices all have end-to-end testing.

Last remark, you can probably:
use useCaseHomeAndSettings instead of useCaseHome + useCaseSettings
use useCaseAddressReview instead of nbgl_useCaseReviewStart + nbgl_useCaseAddressConfirmation
We have a good example in our boilerplate app. It would be more simple & easier to maintain (with the guarantee to be aligned with the design guidelines)

I have made the corresponding modifications. Because I also want to make some changes in the UI aspect, originally I planned to submit them together at that time, but now let's first submit this part.

CodeQL test failure is likely due to repository configuration issues: #84 (comment), it is running well in my repository: https://github.com/lightsail-network/app-stellar/actions/runs/9869736057

Ok ty @overcat I will approve & merge this PR