Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release #85

Closed
wants to merge 6 commits into from
Closed

New Release #85

wants to merge 6 commits into from

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Jul 10, 2024

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@overcat overcat changed the title feat: give an alert when enabling hash signing in settings. (#46) feat: give an alert when enabling hash signing in settings. Jul 10, 2024
@overcat
Copy link
Contributor Author

overcat commented Jul 10, 2024

Hi @tdejoigny-ledger, If you have not yet moved on to the next step, could you also merge this PR? If you have already moved on to the next process, then let's merge it next time.

@tdejoigny-ledger
Copy link
Contributor

Hi @tdejoigny-ledger, If you have not yet moved on to the next step, could you also merge this PR? If you have already moved on to the next process, then let's merge it next time.

sorry @overcat too late 😅

@overcat overcat changed the title feat: give an alert when enabling hash signing in settings. New Release Jul 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.36%. Comparing base (3d5896b) to head (88e0122).
Report is 41 commits behind head on develop.

Files Patch % Lines
libstellar/parser.c 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #85       +/-   ##
============================================
+ Coverage    76.87%   89.36%   +12.48%     
============================================
  Files           14        5        -9     
  Lines         2378     2688      +310     
============================================
+ Hits          1828     2402      +574     
+ Misses         550      286      -264     
Flag Coverage Δ
unittests 89.36% <95.45%> (+12.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@overcat overcat closed this Jul 21, 2024
@overcat overcat deleted the pub2 branch July 22, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants