Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #86

Merged
merged 24 commits into from
Jul 26, 2024
Merged

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Jul 22, 2024

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped
  • Add e2e tests for Flex
  • Update Stax test to support API 21.
  • Improve the coverage of fuzz testing.
  • Optimize the signing process and add necessary alerts.
  • The hash signing setting has been removed, you can consider it as enabled by default.
  • Add support for more Soroban tokens.
  • Fix the bug on the audit report.

Perhaps we need to disable the default CodeQL scan configuration. Otherwise, the CodeQL CI will not pass.
https://docs.github.com/en/code-security/code-scanning/troubleshooting-sarif-uploads/default-setup-enabled

known issue: LedgerHQ/ledger-secure-sdk#737

@overcat overcat marked this pull request as ready for review July 22, 2024 06:59
@vforgeoux-ledger
Copy link
Member

App functionally reviewed ✅
Pending review of the on-going security audit report then the PR will be ready to be merged and Stellar app update to be pushed to the store.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Comment on lines +159 to +162
// TODO: SDK bug, waiting for fix
// if (G_context.unverified_contracts) {
// op_type |= BLIND_OPERATION;
// }

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@tdejoigny-ledger tdejoigny-ledger merged commit d589163 into LedgerHQ:develop Jul 26, 2024
135 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants