We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up for #1858 and #2015
Lemmy detects and decodes encoding when fetching articles, but not completely support encoding aliases such as Shift_JIS. Example: https://www.itmedia.co.jp/news/spv/2212/16/news161.html
Shift_JIS
rust-encoding supports Shift_JIS as an alias of Windows-31J. https://github.com/lifthrasiir/rust-encoding/blob/4e79c35ab6a351881a86dbff565c4db0085cc113/src/codec/japanese.rs#L454
Windows-31J
Current implementation only checks for name but not whatwg_name which has shift_jis.
name
whatwg_name
shift_jis
lemmy/crates/api_common/src/request.rs
Line 60 in ceff2ec
So Lemmy doesn't currently decode Japanese pages which uses Shift_JIS.
The text was updated successfully, but these errors were encountered:
Feel free to make a PR, seems like an easy fix.
Sorry, something went wrong.
I never wrote any Rust code. That's why I opened an issue instead of a PR.
Stale issue, can re-open if someone wants to take it on.
I dont think it makes sense to mark an issue like this as "stale" when it can still be reproduced and still needs to be fixed.
This appears to be fixed, the preview shows Japanese characters.
No branches or pull requests
Issue Summary
Follow up for #1858 and #2015
Lemmy detects and decodes encoding when fetching articles, but not completely support encoding aliases such as
Shift_JIS
.Example: https://www.itmedia.co.jp/news/spv/2212/16/news161.html
rust-encoding supports
Shift_JIS
as an alias ofWindows-31J
.https://github.com/lifthrasiir/rust-encoding/blob/4e79c35ab6a351881a86dbff565c4db0085cc113/src/codec/japanese.rs#L454
Current implementation only checks for
name
but notwhatwg_name
which hasshift_jis
.lemmy/crates/api_common/src/request.rs
Line 60 in ceff2ec
So Lemmy doesn't currently decode Japanese pages which uses
Shift_JIS
.Steps to Reproduce
Shift_JIS
Technical details
The text was updated successfully, but these errors were encountered: