Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mime check fixes. #5213

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Mime check fixes. #5213

merged 2 commits into from
Nov 19, 2024

Conversation

dessalines
Copy link
Member

A cleaner way to do the mime checking.

@dessalines dessalines mentioned this pull request Nov 19, 2024
Merged
@Nutomic Nutomic merged commit 170e3b1 into guess-mime Nov 19, 2024
1 of 2 checks passed
@Nothing4You
Copy link
Collaborator

Nothing4You commented Nov 19, 2024 •
edited
Loading

nvm, didn't realize this PR was against the other PR branch

@SleeplessOne1917 SleeplessOne1917 deleted the guess-mime-dess branch November 19, 2024 14:43
dessalines added a commit that referenced this pull request Nov 19, 2024
@Nutomic @dessalines
Guess image mime type from file extension (fixes #5196) (#5212)
63ea99d 
* Guess image mime type from file extension (fixes #5196)

* Mime check fixes. (#5213)

* Mime check fixes.

* Adding back comment.

---------

Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nutomic Nutomic Nutomic approved these changes

@phiresky phiresky Awaiting requested review from phiresky

@dullbananas dullbananas Awaiting requested review from dullbananas

@SleeplessOne1917 SleeplessOne1917 Awaiting requested review from SleeplessOne1917

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dessalines @Nothing4You @Nutomic