Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Dart benchmark #146

Open
LesnyRumcajs opened this issue May 19, 2021 · 2 comments · Fixed by #325 · May be fixed by #454
Open

Re-enable Dart benchmark #146

LesnyRumcajs opened this issue May 19, 2021 · 2 comments · Fixed by #325 · May be fixed by #454
Labels
good first issue Good for newcomers

Comments

@LesnyRumcajs
Copy link
Owner

Dart benchmark stopped working. It was disabled temporarily, would be nice to re-enable it once the issue is identified and fixed.
@LesnyRumcajs LesnyRumcajs added the good first issue Good for newcomers label Jan 17, 2022
amondnet added a commit to amondnet/grpc_bench that referenced this issue Feb 2, 2023
@amondnet
feat: re-enable dart benchmark
46404c0 
close LesnyRumcajs#146
@amondnet amondnet mentioned this issue Feb 2, 2023
Merged
amondnet added a commit to amondnet/grpc_bench that referenced this issue Feb 2, 2023
@amondnet
feat: re-enable dart benchmark
4b42e09 
close LesnyRumcajs#146
amondnet added a commit to amondnet/grpc_bench that referenced this issue Feb 2, 2023
@amondnet
feat: re-enable dart benchmark
8abe550 
close LesnyRumcajs#146
LesnyRumcajs pushed a commit that referenced this issue Feb 2, 2023
@amondnet
feat: re-enable dart benchmark (#325)
ead54ba 
* feat: re-enable dart benchmark

close #146

* feat: re-enable dart benchmark

close #146

* feat: re-enable dart benchmark

close #146

* feat: re-enable dart benchmark
@LesnyRumcajs
Copy link
Owner Author

LesnyRumcajs commented Mar 5, 2023 •
edited
Loading

Dart is not working again. Perhaps a kind of additional lockfiles need to be introduced there; I am not familiar with the Dart ecosystem. I put it on hold in #333

@LesnyRumcajs LesnyRumcajs reopened this Mar 5, 2023
@amka amka mentioned this issue Jul 3, 2023
Closed
@amka
Copy link

amka commented Jul 3, 2023

Hey @LesnyRumcajs! I filled out the PR to fix this.

@owensdj owensdj linked a pull request Apr 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@amka @LesnyRumcajs