-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test new linux prebuild #675
Comments
Install works and tests pass in these docker images:
|
Also OK on:
|
On FreeBSD 12.0 with node 12.8.1, the prebuild fails to load with:
But |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ok on Ubuntu 19.04 with node 12.11.1 |
Weirdly it even worked on an Ubuntu 12.04 system I happen to have running, with Node 10. That's an older libc but maybe it's not getting newer symbols involved. So that's pretty impressive. |
Ok on RedHat RHEL 7.2, with node LTS |
So, good to release? |
Released 5.3.0 (took a while due to queued CI jobs). Thanks all! |
Since #674, our prebuilt binary for linux is made on CentOS 7 rather than Ubuntu 16.04, making the binary compatible with Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7. Before releasing 5.3.0 we'd like to test the binary on various linux flavors, including those we already supported.
To do so, run
npm i leveldown@next
(5.3.0-0). If it unexpectedly falls back to compiling, raise your hand. If you have time to spare, also run a more thorough test:git clone --recurse-submodules https://github.com/Level/leveldown.git cd leveldown rm build/ -rf npm install npm run download-prebuilds npm run test-prebuild
Comment below with results. Thanks!
@ralphtheninja @rvagg @peakji
The text was updated successfully, but these errors were encountered: