Merge branch 'feature/5275_clean_progress_bar_print' of https://github.com/asnorkin/pytorch-lightning into feature/5275_clean_progress_bar_print

Author: Alexander Snorkin

CHANGELOG.md

@@ -54,6 +54,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Added missing val/test hooks in `LightningModule` ([#5467](https://github.com/PyTorchLightning/pytorch-lightning/pull/5467))
 
 
+- `Recall` and `Precision` metrics (and their functional counterparts `recall` and `precision`) can now be generalized to Recall@K and Precision@K with the use of `top_k` parameter ([#4842](https://github.com/PyTorchLightning/pytorch-lightning/pull/4842))
+
+
+
 ### Changed
 
 - Changed `stat_scores` metric now calculates stat scores over all classes and gains new parameters, in line with the new `StatScores` metric ([#4839](https://github.com/PyTorchLightning/pytorch-lightning/pull/4839))

docs/source/metrics.rst

@@ -382,8 +382,8 @@ the possible class labels are 0, 1, 2, 3, etc. Below are some examples of differ
     ml_target = torch.tensor([[0, 1, 1], [1, 0, 0], [0, 0, 0]])
 
 
-Using the ``is_multiclass`` parameter
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Using the is_multiclass parameter
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 In some cases, you might have inputs which appear to be (multi-dimensional) multi-class
 but are actually binary/multi-label - for example, if both predictions and targets are
@@ -602,14 +602,14 @@ roc [func]
 precision [func]
 ~~~~~~~~~~~~~~~~
 
-.. autofunction:: pytorch_lightning.metrics.functional.classification.precision
+.. autofunction:: pytorch_lightning.metrics.functional.precision
     :noindex:
 
 
 precision_recall [func]
 ~~~~~~~~~~~~~~~~~~~~~~~
 
-.. autofunction:: pytorch_lightning.metrics.functional.classification.precision_recall
+.. autofunction:: pytorch_lightning.metrics.functional.precision_recall
     :noindex:
 
 
@@ -623,7 +623,7 @@ precision_recall_curve [func]
 recall [func]
 ~~~~~~~~~~~~~
 
-.. autofunction:: pytorch_lightning.metrics.functional.classification.recall
+.. autofunction:: pytorch_lightning.metrics.functional.recall
     :noindex:
 
 select_topk [func]

pyproject.toml

@@ -23,18 +23,6 @@ known_first_party = [
     "tests",
 ]
 skip_glob = [
-    # todo
-    "pytorch_lightning/accelerators/*",
-
-
-    # todo
-    "pytorch_lightning/callbacks/*",
-
-
-    # todo
-    "pytorch_lightning/cluster_environments/*",
-
-
     # todo
     "pytorch_lightning/core/*",
 
@@ -43,28 +31,8 @@ skip_glob = [
     "pytorch_lightning/distributed/*",
 
 
-    # todo
-    "pytorch_lightning/metrics/*",
-
-
-    # todo
-    "pytorch_lightning/overrides/*",
-
-
     # todo
     "pytorch_lightning/plugins/*",
-
-
-    # todo
-    "pytorch_lightning/profiler/*",
-
-
-    # todo
-    "pytorch_lightning/trainer/*",
-
-
-    # todo
-    "pytorch_lightning/tuner/*",
 ]
 profile = "black"
 line_length = 120

pytorch_lightning/accelerators/__init__.py

@@ -11,15 +11,15 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+from pytorch_lightning.accelerators.accelerator import Accelerator  # noqa: F401
 from pytorch_lightning.accelerators.cpu_accelerator import CPUAccelerator  # noqa: F401
 from pytorch_lightning.accelerators.ddp2_accelerator import DDP2Accelerator  # noqa: F401
 from pytorch_lightning.accelerators.ddp_accelerator import DDPAccelerator  # noqa: F401
-from pytorch_lightning.accelerators.ddp_spawn_accelerator import DDPSpawnAccelerator  # noqa: F401
+from pytorch_lightning.accelerators.ddp_cpu_hpc_accelerator import DDPCPUHPCAccelerator  # noqa: F401
 from pytorch_lightning.accelerators.ddp_cpu_spawn_accelerator import DDPCPUSpawnAccelerator  # noqa: F401
+from pytorch_lightning.accelerators.ddp_hpc_accelerator import DDPHPCAccelerator  # noqa: F401
+from pytorch_lightning.accelerators.ddp_spawn_accelerator import DDPSpawnAccelerator  # noqa: F401
 from pytorch_lightning.accelerators.dp_accelerator import DataParallelAccelerator  # noqa: F401
 from pytorch_lightning.accelerators.gpu_accelerator import GPUAccelerator  # noqa: F401
-from pytorch_lightning.accelerators.tpu_accelerator import TPUAccelerator  # noqa: F401
 from pytorch_lightning.accelerators.horovod_accelerator import HorovodAccelerator  # noqa: F401
-from pytorch_lightning.accelerators.ddp_hpc_accelerator import DDPHPCAccelerator  # noqa: F401
-from pytorch_lightning.accelerators.ddp_cpu_hpc_accelerator import DDPCPUHPCAccelerator  # noqa: F401
-from pytorch_lightning.accelerators.accelerator import Accelerator  # noqa: F401
+from pytorch_lightning.accelerators.tpu_accelerator import TPUAccelerator  # noqa: F401

pytorch_lightning/accelerators/accelerator_connector.py

@@ -15,13 +15,19 @@
 
 import torch
 
-from pytorch_lightning.utilities import _HOROVOD_AVAILABLE, DeviceType, DistributedType
 from pytorch_lightning import _logger as log
 from pytorch_lightning import accelerators
 from pytorch_lightning.accelerators.accelerator import Accelerator
 from pytorch_lightning.cluster_environments.slurm_environment import SLURMEnvironment
 from pytorch_lightning.cluster_environments.torchelastic_environment import TorchElasticEnvironment
-from pytorch_lightning.utilities import device_parser, rank_zero_only, _TPU_AVAILABLE
+from pytorch_lightning.utilities import (
+    _HOROVOD_AVAILABLE,
+    _TPU_AVAILABLE,
+    device_parser,
+    DeviceType,
+    DistributedType,
+    rank_zero_only,
+)
 from pytorch_lightning.utilities.distributed import rank_zero_info, rank_zero_warn
 from pytorch_lightning.utilities.exceptions import MisconfigurationException
 

pytorch_lightning/accelerators/cpu_accelerator.py

@@ -11,7 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-from typing import Any, Optional, Union, Callable
+from typing import Any, Callable, Optional, Union
 
 import torch
 

pytorch_lightning/accelerators/horovod_accelerator.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 from contextlib import ExitStack
-from typing import Any, Optional, Union, Callable
+from typing import Any, Callable, Optional, Union
 
 import torch
 from torch.optim.lr_scheduler import _LRScheduler

pytorch_lightning/callbacks/gpu_stats_monitor.py

@@ -27,7 +27,7 @@
 from typing import Dict, List, Tuple
 
 from pytorch_lightning.callbacks.base import Callback
-from pytorch_lightning.utilities import rank_zero_only, DeviceType
+from pytorch_lightning.utilities import DeviceType, rank_zero_only
 from pytorch_lightning.utilities.exceptions import MisconfigurationException
 from pytorch_lightning.utilities.parsing import AttributeDict
 

pytorch_lightning/cluster_environments/slurm_environment.py

@@ -14,6 +14,7 @@
 
 import os
 import re
+
 from pytorch_lightning import _logger as log
 from pytorch_lightning.cluster_environments.cluster_environment import ClusterEnvironment
 

pytorch_lightning/cluster_environments/torchelastic_environment.py

@@ -13,9 +13,10 @@
 # limitations under the License.
 
 import os
+
 from pytorch_lightning import _logger as log
-from pytorch_lightning.utilities import rank_zero_warn
 from pytorch_lightning.cluster_environments.cluster_environment import ClusterEnvironment
+from pytorch_lightning.utilities import rank_zero_warn
 
 
 class TorchElasticEnvironment(ClusterEnvironment):