Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
Borda authored and williamFalcon committed Aug 6, 2020
1 parent 88a4e12 commit d6a7e43
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

- Fixed shell injection vulnerability in subprocess call ([#2786](https://github.com/PyTorchLightning/pytorch-lightning/pull/2786))

- Fixed lr finder and hparams compatibility ([#2821](https://github.com/PyTorchLightning/pytorch-lightning/pull/2821))
- Fixed LR finder and `hparams` compatibility ([#2821](https://github.com/PyTorchLightning/pytorch-lightning/pull/2821))

## [0.8.5] - 2020-07-09

Expand Down
3 changes: 3 additions & 0 deletions tests/utilities/parsing.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,17 @@ class TestModel1: # test for namespace

class TestModel2: # test for hparams namespace
hparams = TestHparamsNamespace()

model2 = TestModel2()

class TestModel3: # test for hparams dict
hparams = TestHparamsDict

model3 = TestModel3()

class TestModel4: # fail case
batch_size = 1

model4 = TestModel4()

return model1, model2, model3, model4
Expand Down

0 comments on commit d6a7e43

Please sign in to comment.