From d6a7e43b1daf0c5e46b5ca4e2eeebf5b0ea10318 Mon Sep 17 00:00:00 2001 From: Jirka Borovec Date: Thu, 6 Aug 2020 00:05:23 +0200 Subject: [PATCH] Apply suggestions from code review --- CHANGELOG.md | 2 +- tests/utilities/parsing.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2ef9dccd5409f..ad315d59e3bf5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -94,7 +94,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Fixed shell injection vulnerability in subprocess call ([#2786](https://github.com/PyTorchLightning/pytorch-lightning/pull/2786)) -- Fixed lr finder and hparams compatibility ([#2821](https://github.com/PyTorchLightning/pytorch-lightning/pull/2821)) +- Fixed LR finder and `hparams` compatibility ([#2821](https://github.com/PyTorchLightning/pytorch-lightning/pull/2821)) ## [0.8.5] - 2020-07-09 diff --git a/tests/utilities/parsing.py b/tests/utilities/parsing.py index 249a504a73c5d..469eca74e7ce1 100644 --- a/tests/utilities/parsing.py +++ b/tests/utilities/parsing.py @@ -15,14 +15,17 @@ class TestModel1: # test for namespace class TestModel2: # test for hparams namespace hparams = TestHparamsNamespace() + model2 = TestModel2() class TestModel3: # test for hparams dict hparams = TestHparamsDict + model3 = TestModel3() class TestModel4: # fail case batch_size = 1 + model4 = TestModel4() return model1, model2, model3, model4