Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize test env #1372

Closed
Borda opened this issue Apr 4, 2020 · 3 comments
Closed

Dockerize test env #1372

Borda opened this issue Apr 4, 2020 · 3 comments
Labels
ci Continuous Integration feature Is an improvement or enhancement help wanted Open to be worked on
Milestone

Comments

@Borda
Copy link
Member

Borda commented Apr 4, 2020

🚀 Feature

the simples way for speedup builds is have a docker image with all dependencies then preserving pip cache, that means we will create a docker image which will be pulled

Motivation

for that, the simples way is hawing it id docker hub as it is a native location for almost all CI
these "devel-lightning" docker images can be simply used by any contributor for testing lol

Pitch

we may also have a docker image with installed lightning and all requirements which would make the starting with lightning even easier and it would be also useful for people working on a production

Alternatives

Additional context

later I may configure a cron do this docker build every week

@Borda Borda added feature Is an improvement or enhancement help wanted Open to be worked on ci Continuous Integration labels Apr 4, 2020
@Borda Borda added this to the 0.7.3 milestone Apr 4, 2020
@luiscape
Copy link
Contributor

luiscape commented Apr 6, 2020

Given that Lightning doesn't have a lot of dependencies, I think this is a good idea. The one risk is that the image becomes stale when dependencies change and the image isn't updated. (One can solve that by updating the image every time there's an update in a dependency.)

On a related note, it seems to be that we should pin all dependency versions instead of having them use comparison terms like >. It's hard to know which exact version will be installed when the image is built and it also carries the risk of a dependency update breaking things.

@Borda
Copy link
Member Author

Borda commented Apr 6, 2020

We will have a weekly builds and also we keep their pip install requirements.txt so if there is something new (missing in the Docker image) it will be installed standard way till new image is built...

This was referenced Apr 24, 2020
@Borda Borda modified the milestones: 0.7.4, 0.7.5 Apr 24, 2020
@Borda Borda modified the milestones: 0.7.6, 0.8.0, 0.7.7 May 12, 2020
@Borda Borda modified the milestones: 0.7.7, 0.8.0 May 26, 2020
@Borda Borda modified the milestones: 0.8.0, 0.9.0 Jun 9, 2020
@Borda
Copy link
Member Author

Borda commented Aug 4, 2020

done in #1584 #2779

@Borda Borda closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants