-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Shorthand notation to instantiate datamodules #10011
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
feature
Is an improvement or enhancement
data handling
Generic data-related topic
argparse (removed)
Related to argument parsing (argparse, Hydra, ...)
labels
Oct 19, 2021
carmocca
requested review from
awaelchli,
Borda,
edenlightning,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 19, 2021 02:14
Codecov Report
@@ Coverage Diff @@
## master #10011 +/- ##
=======================================
Coverage 93% 93%
=======================================
Files 180 180
Lines 15877 15882 +5
=======================================
+ Hits 14698 14703 +5
Misses 1179 1179 |
awaelchli
approved these changes
Oct 19, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
tchaton
reviewed
Oct 19, 2021
tchaton
approved these changes
Oct 19, 2021
Borda
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
argparse (removed)
Related to argument parsing (argparse, Hydra, ...)
data handling
Generic data-related topic
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7250
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review