Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed deprecated weights_summary argument from Trainer #13070

Merged
merged 18 commits into from
May 31, 2022
Merged

Removed deprecated weights_summary argument from Trainer #13070

merged 18 commits into from
May 31, 2022

Conversation

shenoynikhil
Copy link
Contributor

@shenoynikhil shenoynikhil commented May 14, 2022 •
edited by Borda
Loading

What does this PR do?

Part of #12521

resolves #9699

This PR removes the weights_summary in the Trainer Class and the corresponding changes. Made the following edits,

  • Removed Argument from Trainer Class [Link]
  • Removed functionality from Callback_Collector Class (Link)
  • Removed test in test_model_summary.py (Link and Link)
  • Removed Deprecation tests related to weights_summary (Link)
  • Removed documentation from trainer.rst (Link)

Does your PR introduce any breaking changes? If yes, please list them.

-Trainer(weights_summary=None)
+Trainer(enable_model_summary=False)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@shenoynikhil shenoynikhil changed the title Remove weights summary [WIP] Remove weights summary from Trainer May 14, 2022
@shenoynikhil shenoynikhil marked this pull request as ready for review May 14, 2022 06:39
@mergify mergify bot removed the has conflicts label May 14, 2022
@shenoynikhil shenoynikhil changed the title [WIP] Remove weights summary from Trainer Remove weights summary from Trainer May 14, 2022
@shenoynikhil shenoynikhil changed the title Remove weights summary from Trainer Remove weights_summary argument from Trainer May 14, 2022
@shenoynikhil
Copy link
Contributor Author

@akihironitta Can you also replace the PR mentioned against the issue in #12521 with this PR. The earlier version of PR was closed due to some issue.

@akihironitta akihironitta mentioned this pull request May 14, 2022
Closed
44 tasks
awaelchli
awaelchli suggested changes May 14, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far!

pytorch_lightning/trainer/connectors/callback_connector.py Outdated Show resolved Hide resolved
tests/utilities/test_model_summary.py Outdated Show resolved Hide resolved
tests/utilities/test_model_summary.py Show resolved Hide resolved
@awaelchli awaelchli added the deprecation Includes a deprecation label May 14, 2022
@shenoynikhil shenoynikhil requested a review from awaelchli May 14, 2022 18:20
awaelchli
awaelchli approved these changes May 14, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@shenoynikhil shenoynikhil changed the title Remove weights_summary argument from Trainer Remove weights_summary argument from Trainer May 15, 2022
@shenoynikhil shenoynikhil changed the title Remove weights_summary argument from Trainer Removed weights_summary argument from Trainer May 15, 2022
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels May 15, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 16, 2022
akihironitta
akihironitta approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

carmocca
carmocca approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed ModelSummaryMode too (now unused)

@carmocca carmocca enabled auto-merge (squash) May 18, 2022 15:10
@Borda Borda changed the title Removed weights_summary argument from Trainer Removed deprecated weights_summary argument from Trainer May 20, 2022
carmocca
carmocca reviewed May 31, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatekeeper

@carmocca carmocca merged commit f4f14bb into Lightning-AI:master May 31, 2022
@carmocca carmocca removed the deprecation Includes a deprecation label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@akihironitta akihironitta akihironitta approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@awaelchli awaelchli

Labels
breaking change Includes a breaking change callback: model summary ready PRs ready to be merged trainer: argument
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@shenoynikhil @ananthsub @awaelchli @Borda @carmocca @akihironitta @rohitgr7