Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary Fix for docs build failure #1413

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Temporary Fix for docs build failure #1413

merged 2 commits into from
Apr 8, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 8, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixed docs build error in #1347

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 8, 2020 09:06
@awaelchli
Copy link
Contributor Author

Hope this fixes it, I will look into pinning the versions for the docs packages this weekend when I have time

@awaelchli awaelchli mentioned this pull request Apr 8, 2020
Merged
5 tasks
@awaelchli awaelchli marked this pull request as ready for review April 8, 2020 09:10
@codecov
Copy link

codecov bot commented Apr 8, 2020 •
edited
Loading

Codecov Report

Merging #1413 into master will not change coverage by %.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1413   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files          63      63           
  Lines        3336    3336           
======================================
  Hits         3061    3061           
  Misses        275     275

@Borda Borda added docs Documentation related ci Continuous Integration labels Apr 8, 2020
Borda
Borda approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda Borda requested review from jeremyjordan, justusschock and a team April 8, 2020 10:06
@williamFalcon williamFalcon merged commit 471499c into Lightning-AI:master Apr 8, 2020
@awaelchli awaelchli deleted the patch-1 branch April 13, 2020 17:27
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@Borda @tullie
Temporary Fix for docs build failure (Lightning-AI#1413)
826b700 
* Update requirements.txt

* fix SG typo

Co-authored-by: J. Borovec <jirka.borovec@seznam.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@jeremyjordan jeremyjordan Awaiting requested review from jeremyjordan

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
ci Continuous Integration docs Documentation related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awaelchli @Borda @williamFalcon